Fix mock client strategy #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Strategy returned a invalid array earlier. >The return value is always an array with zero or more elements. >Each element is an array with two keys >['class' => string, 'condition' => mixed] - Added entry in CHANGELOG as well
|
LGTM |
|
thank you! |
|
Any chance this can get a minor version bump? |
|
No, but you should get a patch release. I will do that tonight unless someone else beat me to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Illegal string offset 'class'error:Why?
Mock Client Stategy Discovery is broken without this fix.
Checklist
To Do
I'm not used to phpspec, so I'm not sure if the spec suffices here, or what can be done to improve it. I attempted using HttpClientDiscovery with the strategy set to mock, but that required adding too many dependencies.